[bug#28219] [PATCH] gnu: netcdf: Fix reproducibility issue; remove unneeded references.

[Ludovic Courtès]

Thomas Danckaert <address@hidden> skribis:

> From e6cfb7e09fbeb97bf6ebb6487cdcf782ca594cc7 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <address@hidden>
> Date: Thu, 24 Aug 2017 15:13:02 +0200
> Subject: [PATCH] gnu: netcdf: Fix reproducibility issue; remove unneeded
>  references.
>
> * gnu/packages/maths.scm (netcdf) [arguments]: Add phase to fix the embedded
>   'Configured On' date; truncate reference to compiler store item.
> ---
>  gnu/packages/maths.scm | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index 16c61dda9..4c25f77e2 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -918,6 +918,21 @@ similar to MATLAB, GNU Octave or SciPy.")
>         ("libjpeg" ,libjpeg)))
>      (arguments
>       `(#:configure-flags '("--enable-doxygen" "--enable-dot" "--enable-hdf4")
> +
> +       #:phases (modify-phases %standard-phases
> +         (add-before 'configure 'fix-source-date
> +           (lambda _
> +             (substitute* "./configure"
> +               (("date -u -d \"\\$\\{SOURCE_DATE_EPOCH\\}\"")
> +                "date --date='@0'"))

Perhaps add the explanation you gave as a comment here.

> +             #t))
> +         (add-after 'configure 'patch-settings
> +           (lambda _
> +             (substitute* "libnetcdf.settings"
> +               (("(/gnu/store/)([a-Z0-9]*)" all prefix hash)
> +                (string-append prefix (string-take hash 10) "...")))
> +             #t)))
> +

Likewise, explain that this allows us to get rid of the references to
GCC et al.

I would suggest making it two separate patches.

Otherwise LGTM, thank you!

Ludo’.