[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#28145] [PATCH] build: Do not store two copies of the ISO-9660 super
From: |
Ludovic Courtès |
Subject: |
[bug#28145] [PATCH] build: Do not store two copies of the ISO-9660 superblock anymore. |
Date: |
Tue, 29 Aug 2017 23:38:02 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Danny Milosavljevic <address@hidden> skribis:
> Hi Ludo,
>
> On Tue, 22 Aug 2017 15:07:28 +0200
> address@hidden (Ludovic Courtès) wrote:
>> Danny Milosavljevic <address@hidden> skribis:
>>
>> > * gnu/build/vm.scm (make-iso9660-image): Do not store two copies of the
>> > ISO-9660 superblock anymore.
>>
>> Why is it no longer needed? Otherwise fine with me. :-)
>
> Because we went ahead and now we just read it from the whole disk on boot
> (previously, it only accepted superblocks on partitions, remember?).
>
> Previously on master:
>
> - DVD
> + ISO9660 superblock
> + partition table
> + partition
> + ISO9660 superblock copy <--- GuixSD sees this
>
> Now on master:
>
> - DVD
> + ISO9660 superblock <--- GuixSD sees this
> + partition table
> + partition
> + ISO9660 superblock copy <--- what's this for now?
>
> With the patch:
>
> - DVD
> + ISO9660 superblock <--- GuixSD sees this
> + partition table
> + partition
Thanks for the explanation, got it now.
Ludo’.