[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#28060] [PATCH] gnu: Add emacs-nixos-mode.
From: |
ng0 |
Subject: |
[bug#28060] [PATCH] gnu: Add emacs-nixos-mode. |
Date: |
Sat, 12 Aug 2017 16:46:29 +0000 |
Arun Isaac transcribed 1.1K bytes:
>
> Thanks for the patch!
>
> Oleg Pykhalov writes:
>
> > +(define-public emacs-nixos-mode
> > + (package
> > + (name "emacs-nixos-mode")
> > + (version "1.11.13")
>
> misc/emacs/nix-mode.el says the version number is 1.0. This contradicts
> the release version number 1.11.13. But, I guess we can go with the
> release version number.
>
> > + (arguments
> > + `(#:phases
> > + (modify-phases %standard-phases
> > + (add-after 'unpack 'chdir-elisp
> > + (lambda _
> > + (chdir "misc/emacs"))))))
>
> It is kinda obvious, but do add a short comment explaining why we are
> changing directory.
>
> > + (synopsis "Emacs major mode for editing Nix expressions")
> > + (description "@code{nixos-mode} provides an Emacs major mode for
> > editing
> > +Nix expressions.")
>
> Could you add the following line to the description?
>
> "It supports syntax highlighting, indenting and refilling of comments."
>
> I have taken the above sentence from
> https://github.com/NixOS/nix/blob/master/misc/emacs/README
>
> > + (license license:gpl3+)))
>
> Nix is under the LGPL 2.1 license. So, nix-mode should also be under the
> same license, right?
>
> Could you send an updated patch? Thanks!
We have Nix in (gnu packages package-management).
Why do you fetch it again when we could just add
another output to the nix package?
--
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org
signature.asc
Description: PGP signature
- [bug#28060] [PATCH] gnu: Add emacs-nixos-mode., Oleg Pykhalov, 2017/08/12
- [bug#28060] [PATCH] gnu: Add emacs-nixos-mode., Arun Isaac, 2017/08/12
- [bug#28060] [PATCH] gnu: Add emacs-nixos-mode.,
ng0 <=
- [bug#28060] [PATCH] gnu: Add emacs-nixos-mode., Oleg Pykhalov, 2017/08/12
- [bug#28060] [PATCH] gnu: Add emacs-nixos-mode., ng0, 2017/08/12
- [bug#28060] [PATCH] gnu: Add emacs-nixos-mode., ng0, 2017/08/12
- [bug#28060] [PATCH] gnu: Add emacs-nixos-mode., Oleg Pykhalov, 2017/08/12
- [bug#28060] [PATCH] gnu: Add emacs-nixos-mode., Oleg Pykhalov, 2017/08/12
- bug#28060: [PATCH] gnu: Add emacs-nixos-mode., Arun Isaac, 2017/08/13
[bug#28060] [PATCH] gnu: Add emacs-nixos-mode., Oleg Pykhalov, 2017/08/12