[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#28020] [PATCH] gnu: Add emacs-gitpatch.
From: |
ng0 |
Subject: |
[bug#28020] [PATCH] gnu: Add emacs-gitpatch. |
Date: |
Thu, 10 Aug 2017 16:55:17 +0000 |
Arun Isaac transcribed 1.3K bytes:
>
> ng0 writes:
>
> > gnu: Add emacs-gitpatch.
> >
> > By the way, “gitpatch.el” says different version than release tarball.
> > Do I need to ask a developer?
> > --8<---------------cut here---------------start------------->8---
> > ;; Author: Feng Shu <address@hidden>
> > ;; Homepage: https://github.com/tumashu/gitpatch
> > ;; Keywords: convenience
> > ;; Package-Requires: ((emacs "24.3"))
> > ;; Version: 0.10
> > --8<---------------cut here---------------end--------------->8---
> >
> > >From 9eddf07fa401468738c2f48a25e51ddef2a3ceed Mon Sep 17 00:00:00 2001
> > From: Oleg Pykhalov <address@hidden>
> > Date: Sat, 29 Jul 2017 14:22:48 +0300
> > Subject: [PATCH] gnu: Add emacs-gitpatch.
> >
> > * gnu/packages/emacs.scm (emacs-gitpatch): New variable.
> >
> > Signed-off-by: Arun Isaac <address@hidden>
> >
> > I appreciate the concerns, but
> > I don't think the complete paragraph of "By the way…" should be in the
> > commit message. Please place notes like this as "XXX: ..." or "TODO: ..."
> > in the code if possible.
> > Or is there any reason why this landed in the commit message?
>
> Oops! I didn't notice it was there. Looks like I screwed up big time
> while applying the patch. There's no way to change the commit message
> now, is there?
>
No, don't worry there are some other misshapenings in the commit log.
Mistakes can happen. Though it would be nice to have a checker for this
somehow...
--
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org
signature.asc
Description: PGP signature