bug#26625: [PATCH] gnu : Add unshield.

[Marius Bakke]

address@hidden writes:

> * gnu/packages/compression.scm (unshield): New variable.

[...]

> @@ -40,6 +41,7 @@
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system perl)
>    #:use-module (guix build-system python)
> +  #:use-module (guix build-system cmake)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages assembly)
>    #:use-module (gnu packages autotools)
> @@ -50,6 +52,7 @@
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages python)
>    #:use-module (gnu packages valgrind)
> +  #:use-module (gnu packages tls)

Please try to keep module imports, inputs, etc alphabetically sorted,
when they are so from before.
  
> +(define-public unshield
> +  (package
> +    (name "unshield")
> +    (version "1.4.2")
> +    (source
> +     (origin (method url-fetch)
> +             (uri (string-append 
> "http://github.com/twogood/unshield/archive/";
> +                                 version ".tar.gz"))
> +             (sha256
> +              (base32
> +               "0x7ps644yp5dka2zhb8w0ifqmw3d255jafpzfwv8xbcpgq6fmm2x"))))
> +    (build-system cmake-build-system)
> +    (inputs
> +     `(("zlib" ,zlib)
> +       ("openssl" ,openssl)))
> +    (arguments
> +     `(#:tests? #f)) ; no test target

There is a test script shipped with the source, can you try replacing
the "check" phase with code that executes "./run_tests"?

> +    (home-page "https://github.com/twogood/unshield";)
> +    (synopsis "Tool to extract CAB files.")
> +    (description "Extracts CAB files from InstallShield installers")

So synopses should not end with punctuations, but descriptions do. `guix
lint` should warn about this. It would be good to have a little more
information here as well.

Maybe something like this (minimal variant):

(synopsis "Extract CAB files from InstallShield installers")
(description
 "@command{unshield} is a tool and library for extracting @file{.cab}
 archives from InstallShield installers.")

If this software works with the "normal" .cab files commonly found in MS
Windows systems, it would be good to encapsulate that information too.
Otherwise LGTM.

signature.asc
Description: PGP signature