|
From: | Danny Milosavljevic |
Subject: | bug#26339: [PATCH 02/18] system: Add extlinux support. |
Date: | Sat, 15 Apr 2017 18:03:12 +0200 |
> + bootloader-configuration-file-location In my opinion in UNIX such a thing is called a "file name", so how about bootloader-configururation-file-name ? > + bootloader-configuration-file-procedure How about bootloader-configuration-file-generator Or bootloader-configuration-file-generation-procedure ? > + bootloader-configuration-install-procedure How about bootloader-configuration-installer or bootloader-configuration-installation-procedure ? > + (match-lambda > + (($ <boot-parameters> label _ _ _ kernel kernel-arguments initrd) > + #~(format port "LABEL ~a > + MENU LABEL ~a > + KERNEL ~a > + FDTDIR ~a/lib/dtbs > + INITRD ~a > + APPEND ~a > +~%" > + #$label #$label > + #$kernel #$kernel #$initrd > + (string-join (list address@hidden)))))) I think it would be better to use the field accessor procedures. > + (* 10 timeout)) Magical conversion? Could use a comment... Remainder of the patch LGTM.
[Prev in Thread] | Current Thread | [Next in Thread] |