|
From: | Danny Milosavljevic |
Subject: | bug#26339: [PATCH 01/18] system: Pass <bootloader-parameter> to grub. |
Date: | Sat, 15 Apr 2017 15:04:36 +0200 |
Hi, > + <boot-parameters> I think it's disadvantageous to export the entire structure. It makes the memory layout public and also makes us unable to replace it by a shim easily later - if we ever want to. > +(define (boot-parameters->menu-entry conf) > + (menu-entry > + (label (boot-parameters-label conf)) > + (device (boot-parameters-store-device conf)) > + (device-mount-point (boot-parameters-store-mount-point conf)) > + (linux (boot-parameters-kernel conf)) > + (linux-arguments (boot-parameters-kernel-arguments conf)) > + (initrd (boot-parameters-initrd conf)))) I think this way of using boot-parameters is good and also doesn't need the <boot-parameters> export above.
[Prev in Thread] | Current Thread | [Next in Thread] |