[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26341: [PATCH] build: vm: Add missing module.
From: |
Ludovic Courtès |
Subject: |
bug#26341: [PATCH] build: vm: Add missing module. |
Date: |
Wed, 05 Apr 2017 23:39:06 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Mathieu Othacehe <address@hidden> skribis:
> diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm
> index 3fa318df3..2de664aa7 100644
> --- a/guix/build/syscalls.scm
> +++ b/guix/build/syscalls.scm
> @@ -462,51 +462,51 @@ the returned procedure is called."
> (define UMOUNT_NOFOLLOW 8)
>
> (define mount
> - (let ((proc (if (module-defined? the-scm-module 'mount)
> - (module-ref the-scm-module 'mount)
> - (syscall->procedure int "mount" `(* * * ,unsigned-long
> *)))))
> - (lambda* (source target type #:optional (flags 0) options
> - #:key (update-mtab? #f))
> - "Mount device SOURCE on TARGET as a file system TYPE. Optionally,
> FLAGS
> + (if (module-defined? the-scm-module 'mount)
> + (module-ref the-scm-module 'mount)
> + (let ((proc (syscall->procedure int "mount" `(* * * ,unsigned-long
> *))))
> + (lambda* (source target type #:optional (flags 0) options
> + #:key (update-mtab? #f))
> + "Mount device SOURCE on TARGET as a file system TYPE. Optionally,
> FLAGS
> may be a bitwise-or of the MS_* <sys/mount.h> constants, and OPTIONS may be a
> string. When FLAGS contains MS_REMOUNT, SOURCE and TYPE are ignored. When
> UPDATE-MTAB? is true, update /etc/mtab. Raise a 'system-error' exception on
> error."
That introduces a slight difference: in one case #:update-mtab? is not
honored. That said, it’s probably OK to ignore it; maybe leave an “XXX”
comment above just in case. ;-)
Otherwise LGTM.
Can you send a ‘git format-patch’ thing? (Otherwise I could write the
commit log on your behalf.)
Thanks!
Ludo’.
- bug#26341: [PATCH] build: vm: Add missing module., Mathieu Othacehe, 2017/04/02
- bug#26341: [PATCH] build: vm: Add missing module., Ludovic Courtès, 2017/04/04
- bug#26341: [PATCH] build: vm: Add missing module., Mathieu Othacehe, 2017/04/05
- bug#26341: [PATCH] build: vm: Add missing module., Mathieu Othacehe, 2017/04/05
- bug#26341: [PATCH] build: vm: Add missing module.,
Ludovic Courtès <=
- bug#26341: [PATCH] build: vm: Add missing module., Mathieu Othacehe, 2017/04/06
- bug#26341: [PATCH] build: vm: Add missing module., Ludovic Courtès, 2017/04/06
- bug#26341: [PATCH] build: vm: Add missing module., Ludovic Courtès, 2017/04/07
- bug#26341: [PATCH] build: vm: Add missing module., Mathieu Othacehe, 2017/04/08
- bug#26341: [PATCH] build: vm: Add missing module., Ludovic Courtès, 2017/04/05
bug#26341: [PATCH 1/2] build: syscalls: Allow mount and umount use from static Guile., Mathieu Othacehe, 2017/04/06
bug#26341: [PATCH 0/5] Fix warnings related to syscalls in static Guile., Mathieu Othacehe, 2017/04/08