Re: Use and abuse of ‘computed-origin-method’: the ‘rust-ring’ case

[Efraim Flashner]

On Sun, Dec 29, 2024 at 10:39:41PM +0100, Ludovic Courtès wrote:
> Hey Efraim,
> 
> Ludovic Courtès <ludo@gnu.org> skribis:
> 
> >> +  (package
> >> +    (name "rust-ring")
> >> +    (version "0.17.8.tar.gz")   ; Hack to adjust the output name.
> >> +    (source (origin
> >>               (method git-fetch)
> >>               (uri (git-reference
> >>                      (url "https://github.com/briansmith/ring";)
> >> @@ -4147,182 +4148,185 @@ (define rust-ring-0.17-sources
> >>               (file-name (git-file-name "rust-ring" version))
> >>               (sha256
> >>                (base32 
> >> "0rqfal81bf4l3dja98cajfjq2jbz1rcx7xdp2r33cxrm5y5psr28"))
> >
> > [...]
> >
> >> +    (build-system trivial-build-system)
> >> +    (arguments
> >> +     (list
> >> +       #:modules '((guix build utils))
> >> +       #:builder
> >> +       #~(begin
> >> +           (use-modules (guix build utils))
> >> +           (setenv "PATH"
> >> +                   (string-join
> >> +                     (list (assoc-ref %build-inputs "clang")    ; for 
> >> clang-format
> >> +                           (assoc-ref %build-inputs "go")
> >> +                           (assoc-ref %build-inputs "gzip")
> >> +                           (assoc-ref %build-inputs "nasm")
> >> +                           (assoc-ref %build-inputs "perl")
> >> +                           (assoc-ref %build-inputs "python-minimal")
> >> +                           (assoc-ref %build-inputs "tar"))
> >
> > You could use #+(this-package-native-input "clang"), etc.
> >
> > If it works, I’m all for it!
> 
> Do you think you could submit a patch for it?  Due to the amount of
> rebuilding, I suppose we’ll have to set up a dedicated branch.

I ended up making the changes and pushing them to the rust-team branch.
Rust-team is right after mesa-updates, so we should be landing it soon™

¹ 
https://git.savannah.gnu.org/cgit/guix.git/commit/?h=rust-team&id=39c1a5f48e9f7a175be7b3c22a76d3ec2d9fc840
https://git.savannah.gnu.org/cgit/guix.git/commit/?h=rust-team&id=d255743544c95e17c0868743b99169f31e5b9164
https://git.savannah.gnu.org/cgit/guix.git/commit/?h=rust-team&id=3d03ca61c62ec29ee93d1b23f9a6c6bca2f240dc
https://git.savannah.gnu.org/cgit/guix.git/commit/?h=rust-team&id=2b75efcb306ccecfa3dc5b2d16b7dd57f9f57768

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

signature.asc
Description: PGP signature