Re: [PATCH Cuirass] cuirass: Fix handling of SPECIFICATION-NAME.

[Romain GARBAGE]

On Mon Jun 17, 2024 at 3:42 PM CEST, Ludovic Courtès wrote:
> Hi!

Hi Ludo' !

> Romain GARBAGE <romain.garbage@inria.fr> skribis:
>
> [...]
> > * src/cuirass/base.scm: Handle SPECIFICATION-NAME as a symbol.
> > * src/cuirass/http.scm: Handle SPECIFICATION-NAME as a symbol.
> > * src/cuirass/templates.scm: Fix template generation.
>
> Bonus points if you can mention the affected procedures in the message
> above (I can do it for you otherwise).

Will fix in v2.

> I tested it locally following the instructions from ‘README’.  One case
> where we still get a type error is when triggering evaluation through
> the web interface:
>
>   wget --post-data="" -O/dev/null \
>     http://localhost:8080/jobset/random/hook/evaluate
>
> This leads to this backtrace in ‘cuirass web’:
>
> --8<---------------cut here---------------start------------->8---
> In cuirass/http.scm:
>   1408:46  1 (url-handler #<input-output: socket 44> _ _)
> In ice-9/boot-9.scm:
>   1685:16  0 (raise-exception _ #:continuable? _)
> In procedure string->symbol: Wrong type argument in position 1 (expecting 
> string): random
> --8<---------------cut here---------------end--------------->8---
>
> Note that this in turn causes communication with ‘cuirass register’ over
> the “bridge”, so there could be other issues there.

IIRC I saw that the register part properly handles the symbols.

I made some changes and checked locally, this case seems to be handled
correctly in v2.

Romain