|
From: | Hartmut Goebel |
Subject: | G-exps: thunk instead of top-level references? |
Date: | Wed, 6 Mar 2024 11:07:06 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 |
Hi Ludio,
I'd like to get some advice:
In commit 84c3aafb5a18ad278bbb36df7b70849fe05789c8 "trytond: Avoid top-level references to other modules" your turned a top-level variable which defines into a thunk:
<https://git.savannah.gnu.org/cgit/guix.git/commit/?id=84c3aafb5a18ad278bbb36df7b70849fe05789c8>
-(define %standard-trytond-native-inputs
+(define (%standard-trytond-native-inputs)
`(("python-dateutil" ,python-dateutil)
and the users:
(native-inputs
- `(,@%standard-trytond-native-inputs
+ `(,@(%standard-trytond-native-inputs)
("trytond-purchase" ,trytond-purchase)))
I'm about to change the uses into G-exprs (see below) and wonder whether "%standard-trytond-native-inputs" should still be a thunk or can be turned pack into a top-level variable.
-(define (%standard-trytond-native-inputs)and uses
- `(("python-dateutil" ,python-dateutil)
+(define %standard-trytond-native-inputs
+ (list python-dateutil
- (native-inputs (%standard-trytond-native-inputs))
+ (native-inputs
+ (cons* trytond-account-payment-clearing
+ %standard-trytond-native-inputs))
-- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |
[Prev in Thread] | Current Thread | [Next in Thread] |