guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 04/07: guix: Add compression module.


From: Ludovic Courtès
Subject: Re: 04/07: guix: Add compression module.
Date: Sun, 11 Sep 2022 22:55:25 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)

Hi Mathieu,

That’s a long-overdue factorization, but…

guix-commits@gnu.org skribis:

> +(define-module (guix compression)
> +  #:use-module (guix gexp)
> +  #:use-module (guix ui)
> +  #:use-module ((gnu packages compression) #:hide (zip))

… a (guix …) module Should Not refer to a (gnu …) module¹.  When it
really has to, it should be via lazy-loading at run time, as is done in
(guix build-system …).

While I agree this should be factorize, I wonder if this should be
promoted to (guix compression).  The module name intuitively is a better
fit for the compression-related things currently in (guix utils).

Not sure, maybe (gnu compression) would make more sense?

Ludo’.

¹ For questions of abstraction layering, and also because that’d break
  “make as-derivation”.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]