guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] doc: Update contribution guidelines on patches, etc.


From: Maxime Devos
Subject: Re: [PATCH v2] doc: Update contribution guidelines on patches, etc.
Date: Fri, 2 Sep 2022 20:05:35 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0


On 02-09-2022 15:12, Ludovic Courtès wrote:
Hello,

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

* doc/contributing.texi ("Snippets versus Phases"): Replaced with...
("Modifying Sources"): ... this.  List more use cases and some principles.
It’s been a while; this looks like a nice improvement to me.  It’s a bit
long, but perhaps that’s avoidable.  If there are no objections, I’d say
go for it.

Have you seen my v2? It has a somewhat different structure (the 'Problem -> solution’ structure proposed by Julien), Liliana's patch is more ‘Solution -> relevant problems’.

Liliana's patch works too, but I would like to make sure you haven't overlooked my patch.

If Liliana's patch is preferred, we can go with that one, if my patch is preserved, I could look at addressing the comments on the wording for a v3.

Greetings,
Maxime.

Attachment: OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]