[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] service: systemd: use correct format for LISTEN_FDNAMES
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] service: systemd: use correct format for LISTEN_FDNAMES |
Date: |
Sun, 08 May 2022 01:17:05 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi Bastien,
Bastien Rivière <me@babariviere.com> skribis:
> From fdabd4ee6d43e32cbf9bd85282ff66138ce652b9 Mon Sep 17 00:00:00 2001
> From: Bastien Riviere <me@babariviere.com>
> Date: Sat, 7 May 2022 01:08:28 +0200
> Subject: [PATCH] service: systemd: use correct format for LISTEN_FDNAMES
>
> As in the documentation, LISTEN_FDNAMES is expected to be a "colon-separated
> list of names".
> This patch add the missing delimiter when joining to LISTEN_FDNAMES.
>
> This fixes issues with services, like gpg-agent, which produces this kind of
> error:
>
>> [gpg-agent] Fatal: number of items in LISTEN_FDNAMES (1) does not match
>> LISTEN_FDS (4) in --supervised mode
> ---
> modules/shepherd/service.scm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Good catch. I tweaked the commit log and pushed it as
74817c475b4d66923df89802e50666257dc82a68.
Thank you!
Ludo’.