[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 04/07: inferior: Break cached-channel-instance into two procedures.
|
From: |
Mathieu Othacehe |
|
Subject: |
Re: 04/07: inferior: Break cached-channel-instance into two procedures. |
|
Date: |
Wed, 10 Mar 2021 13:14:38 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hey,
> We need to keep ‘cached-channel-instance’ because it’s part of the
> public API and used outside Guix (in Guix-Jupyter at least). We can use
> ‘define-deprecated’.
>
> Also, I think ‘cached-profile’ doesn’t quite capture what this is
> about. :-) The docstring should mention what COMMITS is. The fact
> that INSTANCES is a thunk is a bit awkward and IMO not great for a
> public interface.
>
> WDYT?
Yeah you're right the abstraction is really not great. I'll tweak
Cuirass to use the existing API instead.
Reverted with: 8898eaec57f6294221888e6dca1802abdd3d5868.
Thanks,
Mathieu