[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Fix incorrect date and commit in Data Service
From: |
zimoun |
Subject: |
Fix incorrect date and commit in Data Service |
Date: |
Tue, 17 Nov 2020 22:57:05 +0100 |
Hi again,
On Tue, 17 Nov 2020 at 22:43, zimoun <zimon.toutoune@gmail.com> wrote:
> Well, the Data Service should filter out the messages only containing
> the header X-Git-Rev (commit hash) and use the date (Date) of the
> message, which is, IMHO, the most accurate way to do. Instead of rely
> on the date of message containing such headers:
>
> X-Git-Oldrev: 3b026eb3b1dd92c653d1a640b1280b96cfea3084
> X-Git-Newrev: b5e51a06de08f446a07f678ff806cd71a355f7
>
> which can miss the correct commit introducing a change of derivation.
The file data-service/branch-updated-emails.scm contains:
(x-git-newrev (assq-ref headers 'x-git-newrev)))
which is the issue. Instead, it should be
(x-git-rev (assq-ref headers 'x-git-rev)))
but maybe some filtering should be applied.
Well, to be continued…
All the best,
simon
- Re: Data Services: use cases, (continued)
Re: Data Services: use cases, Christopher Baines, 2020/11/16
Re: Data Services: use cases, Christopher Baines, 2020/11/16
- Re: Data Services: use cases, zimoun, 2020/11/16
- Re: Data Services: use cases, Christopher Baines, 2020/11/16
- Re: Data Services: use cases, zimoun, 2020/11/16
- Re: Data Services: use cases, Christopher Baines, 2020/11/16
- Re: Data Services: use cases, zimoun, 2020/11/16
- Re: Data Services: use cases, zimoun, 2020/11/17
- Fix incorrect date and commit in Data Service,
zimoun <=
- Re: Fix incorrect date and commit in Data Service, zimoun, 2020/11/17