Re: [PATCH] gnu: oath-toolkit: Update to 2.6.3.

[Leo Famulari]

On Mon, Nov 09, 2020 at 02:18:21PM +0100, Simon Josefsson via Development of 
GNU Guix and the GNU System distribution. wrote:
> * gnu/packages/authentication.scm (oath-toolkit): Update to 2.6.3.  Drop 
> patch.

Thanks!

> -       (patches
> -        (append (search-patches "oath-toolkit-glibc-compat.patch")
> -                (list (origin
> -                        ;; This huge commit updates gnulib for GCC 7 
> compatibility.
> -                        (method url-fetch)
> -                        (uri (string-append
> -                              
> "https://gitlab.com/oath-toolkit/oath-toolkit/commit/";
> -                              
> "2fffce2a471f74a585939c84cce16ef3015e5d3d.diff"))
> -                        (file-name "oath-toolkit-update-gnulib.patch")
> -                        (sha256
> -                         (base32
> -                          
> "088c9s4ay1b54bjqc4mwfs5l3f6357zj5vpw771zlq5g4addd4s0"))))))

I notice that the commit message says "Drop patch", but that this change
actually removes two patches from the oath-toolkit.

It removes the application of both "oath-toolkit-glibc-compat.patch" and
also the "oath-toolkit-update-gnulib.patch". Is that intended?

If so, we should also delete the former's patch file and remove it from
'gnu/local.mk'.