guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: A script to check an edit does not break anything


From: Vincent Legoll
Subject: Re: A script to check an edit does not break anything
Date: Thu, 11 Jun 2020 19:55:51 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

Hello Edouard,

I think you left a hardcoded package name in your script, line 29, fix
with:

s/python-websockets/$package/

Also you sometimes use $package vs ${package}

This kind of thing (maybe converted into scheme what about
`guix before-submit') should be a valuable addition to guix,
it would help beginners (like me do less mistakes) and comitters
could have more confidence in a submission if it has gone through
this. Which would in turn enable us to integrate patches quicker.

WDYT ?

--
Vincent Legoll



reply via email to

[Prev in Thread] Current Thread [Next in Thread]