guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [OUTREACHY]: Integration of desktop environments into GNU Guix


From: Danny Milosavljevic
Subject: Re: [OUTREACHY]: Integration of desktop environments into GNU Guix
Date: Mon, 25 May 2020 21:58:39 +0200

Hi Raghav,

in malcontent, please don't do 

+             (substitute* "libmalcontent/tests/app-filter.c"
+               (((string-append "g_test_add_func \\(\"/app-filter/appinfo\","
+                                " test_app_filter_appinfo\\);")) ""))

Rather do it without string-append.  If the line is too long, that's too bad, 
just have it too long instead of that crazy opaque stuff.

Also, don't stick the "" back there--better in a new line.

I've pushed it to wip-desktop with those changes.

If there are multiple licenses in a package, please elaborate which parts are
under which licenses and whether it's the user that can choose one of those
licenses or whether all of them apply.

Attachment: pgpBqgI8zxCmR.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]