Re: 05/36: vm: Make the device node procedure a parameter.

[Ludovic Courtès]

Hi!

Jan Nieuwenhuizen <address@hidden> skribis:

> We may even want to move this (and "friends") into the qemu-image
> declaration itself; in a much later patch on wip-hurd-vm I have
>
>  (define* qemu-image #:key
> [...]
> -                     (file-system-type "ext4")
> -                     (file-system-options '())
> -                     (device-nodes 'linux)
> +                     (file-system-type (if (hurd-target?) "ext2" "ext4"))
> +                     (file-system-options
> +                      (if (hurd-target?) '("-o" "hurd") '()))
> +                     (device-nodes (if (hurd-target?) 'hurd 'linux))
>
> Having linux-specific defaults in a generic function is kind of awkward;
> we would need to change all callers, or ...

Ah yes, we should do something like that.

Ludo’.