guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 02/36: gnu: guix: Use gnutls-3.6.13 when cross-compiling.


From: Ludovic Courtès
Subject: Re: 02/36: gnu: guix: Use gnutls-3.6.13 when cross-compiling.
Date: Thu, 30 Apr 2020 23:48:02 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hello!

Time for random review comments on ‘wip-hurd-vm’.  :-)

address@hidden skribis:

> commit af9b4d0ba3d55ef89e956f408853548451243e95
> Author: Jan (janneke) Nieuwenhuizen <address@hidden>
> AuthorDate: Fri Apr 10 09:54:02 2020 +0200
>
>     gnu: guix: Use gnutls-3.6.13 when cross-compiling.
>     
>     * gnu/packages/package-management.scm (guix)[propagated-inputs]: When
>     cross-compiling, use patched gnutls-3.6.13.

[...]

>        (propagated-inputs
> -       `(("gnutls" ,guile3.0-gnutls)
> +       `(("gnutls" ,(if (%current-target-system)
> +                        (@@ (gnu packages tls) gnutls-3.6.13)

Please avoid @@ by making ‘gnutls-3.6.13’ public (and making the package
itself hidden if necessary).

Otherwise LGTM!

Ludo’.

Forgive brevity, sent from my Emacs under lockdown.
:-)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]