Re: [PATCH 1/4] utils: Change critical section terminology to worker threads.

[Ludovic Courtès]

Hi,

Christopher Baines <address@hidden> skribis:

> As far as I'm aware, it's necessary to use a separate thread for interacting
> with SQLite as one of the threads used for fibers will be blocked while the
> SQLite query is running.

Indeed.

> This doesn't mean all queries have to be executed one at a time though,
> providing the queries are executed outside the threads used by fibers, and a
> single connection isn't used in multiple threads.

Serialization of database accesses comes from:

  commit 4612a3a70f1e70afa4e0ce00e8cb1a7848dddf58
  Author: Clément Lassieur <address@hidden>
  Date:   Sun Aug 5 13:14:44 2018 +0200

      database: Serialize all database accesses in a thread.

      Fixes <https://bugs.gnu.org/32234>.

Apparently at the time we weren’t quite sure how SQLite would perform if
we accessed it from several threads, but you seem to suggest that it
works fine, right?

Did you try it on a big database like that of berlin?

> These changes start to move in this direction, first by just changing the
> terminology.

That’s also welcome!

Ludo’.