[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Wheel group as polkit admins
From: |
Ludovic Courtès |
Subject: |
Re: Wheel group as polkit admins |
Date: |
Tue, 26 Nov 2019 11:17:21 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi Leo,
Leo Prikler <address@hidden> skribis:
> From 42eedd4d9d64a8432f787e68d64476c59200c1b6 Mon Sep 17 00:00:00 2001
> From: Leo Prikler <address@hidden>
> Date: Sat, 23 Nov 2019 19:51:15 +0100
> Subject: [PATCH 1/2] services: Add polkit-wheel-service.
>
> * gnu/services/desktop.scm: (polkit-wheel): New variable.
> (polkit-wheel-service): New service.
> ---
> gnu/services/desktop.scm | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
> index 0152e86e8a..e58a08e068 100644
> --- a/gnu/services/desktop.scm
> +++ b/gnu/services/desktop.scm
> @@ -135,6 +135,8 @@
> inputattach-configuration?
> inputattach-service-type
>
> + polkit-wheel-service
> +
> %desktop-services))
>
> ;;; Commentary:
> @@ -1064,6 +1066,25 @@ as expected.")))
> (description "Return a service that runs inputattach on a device and
> dispatches events from it.")))
>
> +
> +;;;
> +;;; polkit-wheel-service
> +;;;
> +
> +(define polkit-wheel
> + (file-union
> + "polkit-wheel"
> + `(("share/polkit-1/rules.d/wheel.rules"
> + ,(plain-file
> + "wheel.rules"
> + "polkit.addAdminRule(function(action, subject) {
> + return [\"unix-group:wheel\"];
> +});
> +")))))
> +
> +(define polkit-wheel-service
> + (simple-service 'polkit-wheel polkit-service-type (list polkit-wheel)))
Could you (1) add a comment saying what this does, like you did in the
second patch, and (2) document it in guix.texi, presumably right below
‘polkit-service’?
> From 1585513cc6d96e2f32a56850c9c26551a29d9f0f Mon Sep 17 00:00:00 2001
> From: Leo Prikler <address@hidden>
> Date: Sat, 23 Nov 2019 19:58:11 +0100
> Subject: [PATCH 2/2] services: Add polkit-wheel-service to %desktop-services.
>
> * gnu/services/desktop.scm: (%desktop-services): Add polkit-wheel-service.
OK!
I’ll wait for your updated patch, thank you!
Ludo’.
Re: Wheel group as polkit admins, Marius Bakke, 2019/11/17