[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 01/06: gnu: guile-redis: Update to 1.0.0.
From: |
Ludovic Courtès |
Subject: |
Re: 01/06: gnu: guile-redis: Update to 1.0.0. |
Date: |
Fri, 24 Aug 2018 12:33:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Mark H Weaver <address@hidden> skribis:
> address@hidden (Ludovic Courtès) writes:
>
>> civodul pushed a commit to branch master
>> in repository guix.
>>
>> commit a50eed201bf470b3bd124a2983bcea3453ec698f
>> Author: Ludovic Courtès <address@hidden>
>> Date: Mon Aug 20 14:35:33 2018 +0200
>>
>> gnu: guile-redis: Update to 1.0.0.
>>
>> * gnu/packages/guile.scm (guile-redis): Update to 1.0.0.
>> [source]: Fetch from github.com. Remove snippet.
>> [native-inputs]: Add AUTOCONF, AUTOMAKE, and PKG-CONFIG.
>> ---
>> gnu/packages/guile.scm | 27 ++++++++-------------------
>> 1 file changed, 8 insertions(+), 19 deletions(-)
>>
>> diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
>> index f179f29..358613b 100644
>> --- a/gnu/packages/guile.scm
>> +++ b/gnu/packages/guile.scm
>> @@ -1241,31 +1241,20 @@ above command-line parameters.")
>> (define-public guile-redis
>> (package
>> (name "guile-redis")
>> - (version "0.1.0")
>> + (version "1.0.0")
>> + (home-page "https://github.com/aconchillo/guile-redis")
>> (source (origin
>> (method url-fetch)
>> - (uri (string-append
>> "mirror://savannah/guile-redis/guile-redis-"
>> - version ".tar.gz"))
>> + (uri (string-append home-page "/archive/" version ".tar.gz"))
>
> [...]
>
>> (home-page "https://savannah.nongnu.org/projects/guile-redis/")
>> (synopsis "Redis client library for Guile")
>> (description "Guile-redis provides a Scheme interface to the Redis
>
> This commit introduced a duplicate 'home-page' field. You made the same
> mistake in your recent commit adding 'guile-gcrypt'. I detected these
> problems quickly because I include the "records: detect duplicate field
> initializers" commit on my private branch.
Oops!
> Anyway, in the case of 'guile-gcrypt', both of the home-page
> initializers were the same. In the case of 'guile-redis', they are
> different. They are:
>
>> + (home-page "https://github.com/aconchillo/guile-redis")
> [...]
>> (home-page "https://savannah.nongnu.org/projects/guile-redis/")
>
> Which one is correct? I deleted the second one, because the first one
> is referenced in the source URI field, and initially I didn't notice
> that they were different. Did guile-redis move from Savannah to GitHub?
Yes, it moved to GitHub.
Thanks for fixing these!
Ludo’.