Re: 01/01: gnu: cmake: Delete Emacs library.

[Mark H Weaver]

Hi Oleg,

address@hidden (Oleg Pykhalov) writes:

> wigust pushed a commit to branch core-updates
> in repository guix.
>
> commit f037673c3133ae7453794f1f62eecebf9d06b092
> Author: Oleg Pykhalov <address@hidden>
> Date:   Tue May 22 07:41:45 2018 +0300
>
>     gnu: cmake: Delete Emacs library.
>     
>     * gnu/packages/finance.scm (cmake)[arguments]: Delete Emacs library.

According to "guix refresh -l cmake", this will require 2783 rebuilds on
x86_64, and probably similar numbers of rebuilds on other systems.

I think this is too much for core-updates right now, which has been
officially frozen since April 2.

Also, the commit log is wrong (it says that the changes were in
finance.scm), and:

> @@ -85,6 +85,12 @@
>             " --exclude-regex ^\\(" (string-join skipped-tests "\\|") 
> "\\)$")))
>         #:phases
>         (modify-phases %standard-phases
> +         (add-after 'unpack 'split-package
> +           ;; Remove files that have been packaged in other package recipes.
> +           (lambda _
> +             (delete-file "Auxiliary/cmake-mode.el")
> +             (substitute* "Auxiliary/CMakeLists.txt"
> +               ((".*cmake-mode.el.*") ""))))

this new phase that you've added returns an unspecified value, although
it is supposed to return a boolean to indicate success or failure.
Moreover, we're currently transitioning toward always returning #t from
phases and reporting any errors using exceptions instead.

In core-updates, we've made good progress toward this goal: all phases
for all core packages, and all packages that I build on my GNOME-based
GuixSD system, have been fixed to always return #t.  It would be good to
avoid moving backwards w.r.t. to that goal.

So, I've reverted your commit on 'core-updates'.  After fixing the
commit log and return value of the new phase, how about pushing this to
'core-updates-next' instead?

What do you think?

      Mark