guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 29/88: gnu: Add emacs-let-alist.


From: Oleg Pykhalov
Subject: Re: 29/88: gnu: Add emacs-let-alist.
Date: Fri, 04 May 2018 09:13:43 +0300

Hello Pierre,

Pierre Neidhardt <address@hidden> writes:

[…]

> Wow, impressive work indeed.  Note that you shouuld not have added
> emms-player-simple-mpv since it's superseded by Emms 5.0.

Do you mean ‘emms-player-simple.el’ from:
--8<---------------cut here---------------start------------->8---
tar xf $(~/src/guix/pre-inst-env env GUIX_PACKAGE_PATH= guix build --no-grafts 
-S emacs-emms) emms-5.0/lisp/emms-player-simple.el
--8<---------------cut here---------------end--------------->8---

I didn't check it carefully, but as I see it's not the same because I
don't see ‘json’ mentioned anywhere.  Also ‘cloc’ tells about 1936 lines
of Lisp code in ‘emms-player-simple-mpv’.  I will try ‘emms’ 5.0 later.

> I'll take care of this in a few days unless someone is faster than me :)

OK, thank you!  But please make sure that ‘emms-player-simple.el’ from
Emms is really the same as ‘emms-player-simple-mpv’, which uses MPV IPC
and parses JSON (not just starts a ‘mpv’ process per song or video).

Oleg.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]