Re: [PATCH] gnu: python2-pyicu: Disable failing test.

[Mark Meyer]

Tobias,
thanks for the patch, this works for me :)

Cheers, Mark

On Fri, Dec 15, 2017, at 11:47, Tobias Geerinckx-Rice wrote:
> * gnu/packages/python.scm (python2-pyicu)[arguments]: Add
> ‘delete-failing-test’ phase.
> ---
> 
> Mark,
> 
> ...of course it finishes right after I send that previous e-mail.
> 
> This patch makes the build pass for me. Could you confirm whether it
> works for you?
> 
> Kind regards,
> 
> T G-R
> 
>  gnu/packages/python.scm | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index e36056d45..372b5afe3 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -1130,7 +1130,20 @@ Python 3.3+.")
>      (license license:x11)))
>  
>  (define-public python2-pyicu
> -  (package-with-python2 python-pyicu))
> +  (let ((base (package-with-python2
> +                (strip-python2-variant python-pyicu))))
> +    (package
> +      (inherit base)
> +      (arguments
> +       `(,@(package-arguments base)
> +         #:phases
> +         (modify-phases %standard-phases
> +           (add-before 'check 'delete-failing-test
> +             (lambda _
> +               ;; XXX: This fails due to Unicode issues unique to Python
> 2,
> +               ;; it seems:
> <https://github.com/ovalhub/pyicu/issues/61>.
> +               (delete-file "test/test_Script.py")
> +               #t))))))))
>  
>  (define-public python2-dogtail
>    ;; Python 2 only, as it leads to "TabError: inconsistent use of tabs
>    and
> -- 
> 2.15.0
> 


-- 
  Mark Meyer
  address@hidden