[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fcgiwrap doesn't see gzip
From: |
Ludovic Courtès |
Subject: |
Re: fcgiwrap doesn't see gzip |
Date: |
Tue, 12 Dec 2017 17:09:58 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hello,
Oleg Pykhalov <address@hidden> skribis:
> address@hidden (Ludovic Courtès) writes:
>
>>> I guess, the issue is because fcgiwrap process environment PATH only
>>> contains /gnu/store/…-shadow-4.5/sbin which doesn't include gzip.
>>
>> There are two possible fixes:
>>
>> 1. Set PATH in the execution environment of ‘fcgiwrap’, just like the
>> ‘mcron-shepherd-services’ procedure does;
>>
>> 2. Add a build phase for ‘fcgiwrap’ that ensures that it refers to
>> ‘gzip’ by its absolute file name.
>>
>> I have a preference for #2 because it’s more robust.
>>
>> Could you look into it?
>
> Yes, but I solve this via cgit package. I believe it's good enough. :-)
Good!
> From 9c9ad2a3716b7ad97e80028e0424f3af6c3759a6 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <address@hidden>
> Date: Tue, 12 Dec 2017 18:29:23 +0300
> Subject: [PATCH] gnu: cgit: Patch absolute file names.
>
> * gnu/packages/version-control.scm (cgit): Patch absolute file names.
[...]
> + (lambda* (#:key inputs #:allow-other-keys)
> + (define (quoted-path input path)
> + (string-append "\"" input path "\""))
> + (substitute* "ui-snapshot.c"
> + (("\"gzip\"")
> + (quoted-path (assoc-ref %build-inputs "gzip")
> + "/bin/gzip"))
> + (("\"bzip2\"")
> + (quoted-path (assoc-ref %build-inputs "bzip2")
> + "/bin/bzip2"))
> + (("\"xz\"")
> + (quoted-path (assoc-ref %build-inputs "xz")
> + "/bin/xz")))
Use ‘inputs’ instead of ‘%build-inputs’ (it’s equivalent but IMO
clearer.)
Also I’d suggest “quoted-file-name” or just “quoted” instead of
“quoted-path”. :-)
OK with changes along these lines, thank you!
Ludo’.