Re: [PATCH] qjackctl

[Ludovic Courtès]

Hi Mark,

Thanks for the patches!

They look all right, except a couple of minor details:

Mark Meyer <address@hidden> skribis:

> From 93bdb3c4f6b8d74584ec29ea4f6733c373c44ab2 Mon Sep 17 00:00:00 2001
> From: Mark Meyer <address@hidden>
> Date: Wed, 29 Mar 2017 10:35:46 +0200
> Subject: [PATCH 1/2] Add qjackctl to the audio packages.
>
> ---
>  gnu/packages/audio.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)

Could you try to come up with a ChangeLog-style commit message that
follows our convention?  You can see ‘git log’ for examples of what to
type, and
<https://gnu.org/software/guix/manual/html_node/Submitting-Patches.html>.

Don’t worry too much about it, I can always fix it if there are small
issues, but it’s better if you give it a try.  :-)

> +    (synopsis "A Jack server control application")
> +    (description "Control a Jack server")

Please write a full description; see
<https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html>.

> From 33b194b92c563c370a41cffa485594fb321f2e14 Mon Sep 17 00:00:00 2001
> From: Mark Meyer <address@hidden>
> Date: Wed, 29 Mar 2017 11:41:08 +0200
> Subject: [PATCH 2/2] Add a proper synopsis
>
> ---
>  gnu/packages/audio.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index d1f360d3d..7ebf68ee3 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -1804,7 +1804,7 @@ and ALSA.")
>       `(("pkg-config" ,pkg-config)
>         ("qttools" ,qttools)))
>      (home-page "https://qtjackctl.sourceforge.io";)
> -    (synopsis "A Jack server control application")
> +    (synopsis "A Jack server control application that allows you to plug 
> various sources into various outputs and to start, stop and configure jackd")

The propose synopsis is too long, and the original string was OK as a
synopsis; see
<https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html>.

Could you send an updated patch for qjackctl?  Make sure to run

  ./pre-inst-env guix lint qjackctl

before and to address any issues it reports.

Thanks in advance!

Ludo’.