[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] guix: python-build-system: Properly inform caller about test
From: |
Marius Bakke |
Subject: |
Re: [PATCH] guix: python-build-system: Properly inform caller about test status. |
Date: |
Thu, 05 Jan 2017 14:31:41 +0100 |
User-agent: |
Notmuch/0.23.4 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) |
Danny Milosavljevic <address@hidden> writes:
> * guix/build/python-build-system.scm (check): Properly inform caller about
> test status.
> ---
> guix/build/python-build-system.scm | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/guix/build/python-build-system.scm
> b/guix/build/python-build-system.scm
> index 3f280b0ac..d46739827 100644
> --- a/guix/build/python-build-system.scm
> +++ b/guix/build/python-build-system.scm
> @@ -136,12 +136,13 @@
> ;; build/lib in some cases, e.g. if the source is in a sub-directory
> ;; (given with `package_dir`). This will by copied to the output, too,
> ;; so we need to remove.
> - (let ((before (find-files "build" "\\.egg-info$" #:directories? #t)))
> - (call-setuppy test-target '() use-setuptools?)
> - (let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
> - (inter (lset-difference eqv? after before)))
> - (for-each delete-file-recursively inter)))
> - #t))
> + (let* ((before (find-files "build" "\\.egg-info$" #:directories? #t))
> + (status (call-setuppy test-target '() use-setuptools?))
> + (after (find-files "build" "\\.egg-info$" #:directories? #t))
> + (inter (lset-difference eqv? after before)))
> + (for-each delete-file-recursively inter)
> + status)
> + #t))
This is fixed with e46a043ecd9f9ef46d1d44393362bb7016454544 from the
'python-tests' branch. Speaking of which, there are still some failing
packages in that branch listed at:
https://hydra.gnu.org/eval/109407?compare=master#tabs-now-fail
I'll try to take care of the remaining failures in the next week so we
can merge this branch. Contributions are always welcome however ;-)
signature.asc
Description: PGP signature
- [PATCH] guix: python-build-system: Properly inform caller about test status., Danny Milosavljevic, 2017/01/04
- Re: [PATCH] guix: python-build-system: Properly inform caller about test status., Hartmut Goebel, 2017/01/05
- Re: [PATCH] guix: python-build-system: Properly inform caller about test status.,
Marius Bakke <=
- Re: [PATCH] guix: python-build-system: Properly inform caller about test status., Leo Famulari, 2017/01/05
- python-tests: Sphinx, Danny Milosavljevic, 2017/01/05
- Re: python-tests: Sphinx, Marius Bakke, 2017/01/05
- [PATCH v2 0/6] Make python-oslosphinx work in python-tests branch., Danny Milosavljevic, 2017/01/18
- [PATCH v2 1/6] gnu: python-testtools: Update to 1.4.0., Danny Milosavljevic, 2017/01/18
- Re: [PATCH v2 1/6] gnu: python-testtools: Update to 1.4.0., Marius Bakke, 2017/01/18
- Re: [PATCH v2 1/6] gnu: python-testtools: Update to 1.4.0., Danny Milosavljevic, 2017/01/19
- Re: [PATCH v2 1/6] gnu: python-testtools: Update to 1.4.0., Marius Bakke, 2017/01/19
- python2-traceback2, python2-linecache2, Danny Milosavljevic, 2017/01/19
- Re: python2-traceback2, python2-linecache2, Marius Bakke, 2017/01/19