Re: [PATCH] gnu: Add tipp10 touch typing tutor.

[Hartmut Goebel]

Am 19.12.2016 um 22:39 schrieb Ludovic Courtès:
>
>> +              (uri (string-append "mirror://debian/pool/main/"
>> +                                  "t/tipp10/tipp10_2.1.0.orig.tar.gz"))
> Is there really no upstream for this program?  tipp10.com seems to be
> live, no?

There is, but guix is not able to handle the download URL, which is
<https://www.tipp10.com/en/download/getfile/3/> or
<https://www.tipp10.com/en/download/getfile/3/1483193655/>.This page
uses  "<meta http-equiv="refresh"
content="1;url=/en/download/getfile/3/1483193955/" />". I asked the
author for a different URL, but he did not answer.


>
>> +              (patches (search-patches "tipp10-FixCompiling.patch"
>> +                                       "tipp10-RemoveLicenseCode.patch"))))
> Please use lowercase and hyphens for file names.  :-)

Anything else unimportant I can waste my time on? These are the
file-names of the patches at debian. I see absolutely no benefit in
changing them.


>
>> +    (description " TIPP10 is a free touch typing tutor for Windows, Mac OS 
>> and
>                      ^
> Extra space.
>
> Please don’t mention supported operating systems; what matters is that
> it works on GNU.

IMO this is interesting for users and for spreading free software. If
one reads this i might think: "O, coll, I can recommend this to some
friend still using Windooze and ma convince her about free software."

>
>> +Linux.  The ingenious thing about the software is its intelligence feature.
> “Intelligence feature” sounds vague; could it be rephrased in more
> precise terms?
>
>> +Note: To change the language settings choose Datei (File) →
>> +Grundeinstellungen (Generell Settings) → Sprache (Language) and change from
>> +Deutsch to English. The you have restart the program to have the change take
>> +effect.")
> This information doesn’t belong here.
>
> Does Debian have patches to make this program honor the current locale?
> That would be the best option.

No, there are not patches, this is why I put this information there. If
ou dislike, please recommend a better place.

>
>> +    (license license:gpl2)))
> Version 2 only?

This is what https://www.tipp10.com/en/download/ says.

>
>> +-Exec=tipp10
>> ++Exec=/usr/bin/tipp10
> This doesn’t look useful.

Yes, but this is part of the original Debian patch. I'd prefer to keep
this patch unchanged to make it easier to follow any changes or fixes
Debian incorporates. Since guix is fixing this path anyway, there is no
use in maintaining a own set of patches.

To be frank, some of your comment on this patch are nitpicking at its
best. I have the impression that you did not trust me to have spend only
a little thought on what I'm doing. And you are demanding things (patch
filenames, change to upstream patches) which have no or negligible
benefit – even if seen in the long run. This *very* discouraging!

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | address@hidden               |
| www.crazy-compilers.com | compilers which you thought are impossible |