[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] system: Add btrfs file system support.
From: |
David Craven |
Subject: |
Re: [PATCH 2/2] system: Add btrfs file system support. |
Date: |
Fri, 2 Dec 2016 17:27:24 +0100 |
> How to handle the return codes.
This isn't a problem, the check-procedure can normalize the return codes. The
confusing thing is this part:
(else #~(system* (string-append "fsck." type) device)
The default behavior should be to emit a warning to stderr and do nothing. I
don't think this produces anything useful for any file system...
> I've also wondered about this. I'm not sure how long each test takes to
> run, so an analysis of the tests to find their slow areas might help
> guide us.
I noticed that the system tests in general are fast. It's only the
installer tests that take so long.