Re: [PATCH] gnu: Add libjxr.

[Leo Famulari]

On Fri, Oct 21, 2016 at 04:47:14PM -0400, Kei Kebreau wrote:
> This is a patch I think we need before fixing up freeimage. Thoughts?

Thanks for working on this!

> +              (uri (string-append 
> "mirror://debian/pool/main/j/jxrlib/jxrlib_"
> +                                  version ".orig.tar.gz"))

Why not download it from the upstream site? We prefer to do that when
possible.

https://jxrlib.codeplex.com/releases/view/107208

> +    (license
> +     (license:non-copyleft
> +      "file://Makefile"
> +      "See the header of the Makefile in the distribution."))

That looks like a 2 clause BSD license:
https://opensource.org/licenses/BSD-2-Clause

> diff --git a/gnu/packages/patches/libjxr-fix-typos.patch 
> b/gnu/packages/patches/libjxr-fix-typos.patch
> new file mode 100644
> index 0000000..3c051dd
> --- /dev/null
> +++ b/gnu/packages/patches/libjxr-fix-typos.patch
> @@ -0,0 +1,60 @@
> +Description: Fix typos and remove some warnings
> +Author: Mathieu Malaterre <address@hidden>

Can you include a link to the source of this patch?

> diff --git a/gnu/packages/patches/libjxr-use-cmake.patch 
> b/gnu/packages/patches/libjxr-use-cmake.patch
> new file mode 100644
> index 0000000..cb5919e
> --- /dev/null
> +++ b/gnu/packages/patches/libjxr-use-cmake.patch
> @@ -0,0 +1,143 @@
> +Description: Prefer a cmake based build system
> +Author: Mathieu Malaterre <address@hidden>
> +Forwarded: https://jxrlib.codeplex.com/discussions/440294

Why doesn't upstream's build system work?

signature.asc
Description: PGP signature