Re: [PATCH] gnu: Add geierlein.

[Ricardo Wurmus]

Hartmut Goebel <address@hidden> writes:

> * gnu/packages/finance.scm (geierlein): New variable.

[…]

> +
> +(define-public geierlein
> +  (package
> +    (name "geierlein")
> +    (version "0.9.5")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/stesie/geierlein";
> +                           "/archive/V" version ".tar.gz"))

Please add a “file-name” field here.

> +       (sha256
> +        (base32
> +         "0b11fq8v5w8nxjb20jl4dsfhv76xky6n3sq3k3fbb0m2sq9ikikw"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f ; would require npm, python and a lot more
> +       #:phases
> +        (modify-phases %standard-phases
> +          (delete 'configure)
> +          (add-after 'unpack 'override-target-directory-and-tool-paths
> +            (lambda* (#:key inputs outputs #:allow-other-keys)
> +              (substitute* "Makefile"
> +                (("prefix := .*")
> +                 (string-append "prefix := " (assoc-ref outputs "out") "\n"))
> +                ;; Required for tests, unused for now:
> +                ;;(("PYTHON := .*")
> +                ;; (string-append (which "python") "\n")))
> +                (("INSTALL := .*")
> +                 (string-append "INSTALL := " (which "install") "\n")))
> +              (substitute* "bin/xgeierlein.in"
> +                ;; Use icecat as XULRUNNER
> +                (("^for search ")
> +                 (string-append "XULRUNNER=" (which "icecat") "\n"
> +                                "for search ")))
> +              #t)))))
> +    (inputs
> +     `(("icecat" ,icecat)))
> +    (home-page "http://stesie.github.io/geierlein/";)
> +    (synopsis "Free Elster client, for sending Germany VAT declarations")
> +    (description
> +     "Geierlein is a free Elster client, i.e. an application that
> +allows to send VAT declarations to Germany's fiscal authorities.
> +
> +It's a complete rewrite of its predecessors libgeier & Taxbird.
> +Opposed to these it's completely written in JavaScript and HTML5,
> +hence it should be rather platform independent.

I don’t think this paragraph is needed.

> +Currently it is *not* possible to send returns that are due annually
> +(especially the income tax return) since the fiscal authority doesn't
> +allow to do that off the ERiC library (which is proprietary however).
> +It's not clear at the moment whether one day it will be possible to
> +do so.
> +
> +Please note: Geierlein does not allow to send income tax returns.")

The note seems to be redundant.

The rest is okay.  Thanks!

~~ Ricardo