Re: [PATCH] gnu: lynx: Fix GnuTLS support.

[Kei Kebreau]

Leo Famulari <address@hidden> writes:

> On Sun, Oct 09, 2016 at 01:55:10PM -0400, Kei Kebreau wrote:
>> Leo Famulari <address@hidden> writes:
>> 
>> > On Fri, Oct 07, 2016 at 10:42:38AM -0400, Kei Kebreau wrote:
>> >> I get the same problem here. Lynx does mention that GnuTLS support is
>> >> experimental. Your and Tobias' page work using OpenSSL instead. Try the
>> >> new patch attached.
>> >
>> >> From ee3a889e6902686de4d7c949afcb8cd4a810bd0f Mon Sep 17 00:00:00 2001
>> >> From: Kei Kebreau <address@hidden>
>> >> Date: Fri, 7 Oct 2016 10:36:11 -0400
>> >> Subject: [PATCH] gnu: lynx: Support HTTPS (SSL) connections
>> >> 
>> >> * gnu/packages/lynx.scm (lynx)[inputs]: Add 'openssl' and remove 'gnutls'.
>> >> [arguments]: Add configure flags for OpenSSL support; remove
>> >> configure flags
>> >> for GnuTLS support.
>> >
>> > Thanks, this works for me.
>> >
>> > I think it's fine to use the "dev" releases with GnuTLS too. Debian and
>> > Fedora both use them.
>> 
>> I can confirm that lynx 2.8.9dev.9 works properly with GnuTLS. Should we
>> use the current stable release with OpenSSL or the development release
>> with GnuTLS? And if we use the development release, should I submit the
>> patches as a single version bump with the necessary small adjustments?
>
> I would do it all in one: update to 2.8.9dev.9 and correct the configure
> flags so it works correctly. I think that "update" and "make the updated
> version work correctly" belong in the same commit since one change
> doesn't make sense without the other.

Alright. Does this commit message look good to you?

0001-gnu-lynx-Update-to-2.8.9dev.9-and-fix-GnuTLS-support.patch
Description: Text document

signature.asc
Description: PGP signature