Re: [PATCH 02/12] gnu: Add alexandria.

[Ludovic Courtès]

Andy Patterson <address@hidden> skribis:

> * gnu/packages/lisp.scm (alexandria, alexandria-sbcl, alexandria-ecl):
>   New variables.

[...]

> +(define-public alexandria
> +  (let ((revision "1")
> +        (commit "926a066611b7b11cb71e26c827a271e500888c30"))
> +    (package
> +      (name "alexandria")
> +      (version (string-append "0.0.0-" revision "." (string-take commit 7)))
> +      (source (origin
> +                (method git-fetch)
> +                (uri
> +                 (git-reference
> +                  (url 
> "https://gitlab.common-lisp.net/alexandria/alexandria.git";)
> +                  (commit commit)))
> +                (sha256
> +                 (base32 
> "18yncicdkh294j05rhgm23gzi36y9qy6vrfba8vg69jrxjp1hx8l"))
> +                (file-name (string-append name "-" version "-checkout"))))
> +      (build-system asdf-build-system/source)
> +      (synopsis "Collection of portable utilities for Common Lisp")
> +      (description "Alexandria is a collection of portable utilities.  It 
> does
> +not contain conceptual extensions to Common Lisp.  It is conservative in
> +scope, and portable between implementations.")
> +      (home-page "https://common-lisp.net/project/alexandria/";)
> +      (license license:public-domain))))
> +
> +(define-public alexandria-sbcl
> +  (package
> +    (inherit alexandria)
> +    (name "alexandria-sbcl")
> +    (build-system asdf-build-system/sbcl)
> +    (inputs `(("alexandria" ,alexandria)))))
> +
> +(define-public alexandria-ecl
> +  (package
> +    (inherit alexandria)
> +    (name "alexandria-ecl")
> +    (build-system asdf-build-system/ecl)
> +    (inputs `(("alexandria" ,alexandria)))))

It’s unusual that the “alexandria” package provides the source and that
the others depend on it rather than have an ‘origin’ as their source.
But as you wrote in the build system code, the raw source can be
interpreted by CL implementations other than SBCL or ECL, right?

Otherwise LGTM.

Thanks,
Ludo’.