Re: [PATCH 15/24] gnu: gstreamer: Symlink gstconfig.h into include directory.

[Mark H Weaver]

David Craven <address@hidden> writes:

>> What is the reason for this change?  Would it be appropriate to submit a
>> bug report upstream to add this to their "make install"?
>
> The reason is because applications may contain #include <gst/gstconfig.h>,
> but gstconfig.h was moved to the lib directory because it contains "platform
> specific information".
>
> What do you suggest?

The pkgconfig file for gstreamer, $out/lib/pkgconfig/pkgconfig-1.0.pc,
includes this:

  Cflags: -I${includedir} -I${libdir}/gstreamer-1.0/include

Where ${libdir} is ${prefix}/lib.  So, the include path needed to find
<gst/gstconfig.h> should automatically be included by non-broken build
systems.

What application(s) are you aware of that are unable to find
<gst/gstconfig.h>?

In general, we should stick to upstream packaging unless it is clearly
broken or there is a compelling reason to deviate.  In this case, if an
application can't find <gst/gstconfig.h>, then it would seem to have a
buggy build system, and we should fix the problem there.

What do you think?

    Thanks,
      Mark