Re: [PATCH 07/11] gnu: ncurses: support mingw.

[Alex Kost]

Jan Nieuwenhuizen (2016-08-09 09:41 +0300) wrote:

> * gnu/packages/patches/ncurses-mingw.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.
> * gnu/packages/ncurses.scm (ncurses): Support mingw.
[...]
>  (define-public ncurses
> @@ -36,6 +39,7 @@
>                      #:allow-other-keys)
>              (let ((out (assoc-ref outputs "out"))
>                    (doc (assoc-ref outputs "doc")))
> +              (format #t "configure flags: ~s~%" configure-flags)
>                (zero? (apply system* "./configure"
>                              (string-append "SHELL=" (which "sh"))
>                              (string-append "--build=" build)
> @@ -60,33 +64,66 @@
>                 "mandir=share/man"))
>              #t))
>          (post-install-phase
> -         '(lambda* (#:key outputs #:allow-other-keys)
> -            (let ((out (assoc-ref outputs "out")))
> +         `(lambda* (#:key outputs target #:allow-other-keys)
> +            (let ((out (assoc-ref outputs "out"))
> +                  (mingw-target? (lambda* (#:optional (target target))
> +                                   (and target
> +                                        (string-suffix? "-mingw32" target))))

IIUC you don't use the same 'mingw-target?' procedure you added in an
earlier patch, because it is placed in (guix utils), right?  I don't
know if (guix build utils) would be a better place for it, but I think
this 'mingw-target?' may be used by other packages quite often, so it
should be available by default to avoid the same definitions in other
packages.

-- 
Alex