|
From: | Ludovic Courtès |
Subject: | Re: [PATCH 4/5] import: pypi: Compute test requirements when reading requirements files. |
Date: | Fri, 22 Jul 2016 23:30:37 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Cyril Roelandt <address@hidden> skribis: > * guix/import/pypi.scm (guess-requirement-from-source): Read > test-requirements.txt as well as requirements.txt. > * tests/pypi.scm ("pypi->guix-package"): Update accordingly. [...] > (let* ((req-file (string-append dirname "/requirements.txt")) > - (exit-code (system* "tar" "xf" tarball req-file))) > + (test-req-file (string-append dirname > "/test-requirements.txt")) > + (exit-code (system* "tar" "xf" tarball req-file)) > + (test-exit-code (system* "tar" "xf" tarball test-req-file))) > ;; TODO: support more formats. > - (if (zero? exit-code) > + (if (or (zero? exit-code) > + (zero? test-exit-code)) This seems to suggest that this could be factorized somehow. Maybe unpack once and read the two files at once? Ludo’.
[Prev in Thread] | Current Thread | [Next in Thread] |