Re: Guix on a Dell XPS 13 DE - 9350

[Ludovic Courtès]

Jan Nieuwenhuizen <address@hidden> skribis:

> From 58427605c4b981669b50d953971596ae36f70530 Mon Sep 17 00:00:00 2001
> From: Jan Nieuwenhuizen <address@hidden>
> Date: Thu, 16 Jun 2016 23:58:45 +0200
> Subject: [PATCH 1/4] gnu: Add gptfdisk.
>
> * gnu/packages/disk.scm (gptfdisk): New variable.

[...]

> +(define-public gptfdisk
> +  (package
> +    (name "gptfdisk")

It fails to build here:

--8<---------------cut here---------------start------------->8---
starting phase `check'
make: *** No rule to make target 'check'.  Stop.
phase `check' failed after 0.0 seconds
--8<---------------cut here---------------end--------------->8---

> +    (license gpl2)))

Version 2 only?

Could you send an updated patch?

> From f0ae5fde7c2965b61b62f8e636421a4066b2c1c4 Mon Sep 17 00:00:00 2001
> From: Jan Nieuwenhuizen <address@hidden>
> Date: Thu, 16 Jun 2016 09:50:32 +0200
> Subject: [PATCH 2/4] gnu: linux-initrd: Support NVMe devices.
>
> * gnu/system/linux-initrd.scm (base-initrd): Add nvme to linux-modules.

Applied!

> From 37ab729322b21acd325b43c97b47c8e217635cd1 Mon Sep 17 00:00:00 2001
> From: Jan Nieuwenhuizen <address@hidden>
> Date: Fri, 17 Jun 2016 13:45:28 +0200
> Subject: [PATCH 3/4] nix: Allow ~ in store names.
>
> * nix/libstore/store-api.cc (checkStoreName): Add ~ to validChars.

Nack!  :-)  This looks like a can of worms, so I’d rather change the GRUB
version name.

> From 4dd99e90153bcd57b696234edf52efd2398fb7e4 Mon Sep 17 00:00:00 2001
> From: Jan Nieuwenhuizen <address@hidden>
> Date: Thu, 16 Jun 2016 09:50:27 +0200
> Subject: [PATCH 4/4] gnu: Update grub to 2.02~beta3.
>
> * gnu/packages/grub.scm (grub): Change version no 2.02.beta3, use
> custom url symlinked to 2.02~beta3.

[...]

>  (define-public grub
>    (package
>      (name "grub")
> -    (version "2.00")
> +    (version "2.02~beta3")

Could you make it “2.02beta3”?

>      (source (origin
>               (method url-fetch)
> -             (uri (string-append "mirror://gnu/grub/grub-"
> -                                 version ".tar.xz"))
> +             (uri (string-append
> +                   "ftp://alpha.gnu.org/gnu/grub/grub-";
> +                   version ".tar.xz"))
>               (sha256
>                (base32
> -               "0n64hpmsccvicagvr0c6v0kgp2yw0kgnd3jvsyd26cnwgs7c6kkq"))
> -             (patches (search-patches "grub-gets-undeclared.patch"
> -                                      "grub-freetype.patch"
> -                                      "grub-CVE-2015-8370.patch"))))
> +               "18ddwnw0vxs7zigvah0g6a5z5vvlz0p8fjglxv1h59sjbrakvv1h"))))

Likewise, add a ‘file-name’ here to avoid “~”.

>      (arguments
>       '(#:configure-flags '("--disable-werror")
> +       #:tests? #f ;; fail

That’s cheating.  :-)

Could you explain why/how it fails?  I would rather address it or at
least make sure we have a good understanding of what’s going on.

Thanks!

Ludo’.