Re: [PATCH] gnu: Add warzone2100.

[Kei Kebreau]

Leo Famulari <address@hidden> writes:

> On Wed, Jun 15, 2016 at 09:39:36PM -0400, Kei Kebreau wrote:
>> * gnu/packages/games.scm (warzone2100): New variable.
>
> Cool, it's nice to see games like this continuing to be developed!
>

Indeed it is! Especially since it started out on proprietary consoles
and such.

>> +    (inputs `(("fontconfig" ,fontconfig)
>
> Can you double-check that all these inputs are needed at run-time with
> `guix gc --references`?
>

The binary links to all of the libraries, but doesn't seem to require
the DejaVu fonts. I've also moved the unzip and zip binaries to
native-inputs.

>> +              ("font-dejavu" ,font-dejavu)
>> +              ("freetype" ,freetype)
>> +              ("fribidi" ,fribidi)
>> +              ("glew" ,glew)
>> +              ("libtheora" ,libtheora)
>> +              ("libvorbis" ,libvorbis)
>> +              ("libxrandr" ,libxrandr)
>> +              ("openal" ,openal)
>> +              ("physfs" ,physfs)
>> +              ("qt", qt-4)
>
> Can it run with qt-5? My understanding is that qt-4 is no longer
> supported by upstream and is thus risky from a security perspective.  We
> are slowly working to eliminate dependencies on qt-4 in Guix.
>
> If it can't use qt-5, I guess it's okay, with a friendly bug report to
> upstream :)
>
> If it can use qt-5, then it can take advantage of the modularization
> that Efraim has been working on.

It can't use qt-5 at the moment. Debian is still using the Qt4 script
library and Arch Linux uses a Qt5 compatibility layer of some sort.

An updated patch is attached for review.

0001-gnu-Add-warzone2100.patch
Description: updated patch

-- 
Kei (GPG Key: 4096R/E6A5EE3C19467A0D)

signature.asc
Description: PGP signature