Re: [PATCH] Add msgpack

[Leo Famulari]

On Mon, Jun 13, 2016 at 12:58:52PM -0400, Leo Famulari wrote:
> On Sat, Jun 11, 2016 at 11:24:23PM -0500, Lukas Gradl wrote:
> > Oh, that is true.  I searched around, but I could not find anything
> > about zbuffer.h[pp].  I am not sure what it is used for.  FWIW, it is
> > only referenced in src/Makefile, src/Makefile.in, src/Makefile.am
> > CMakeLists.txt and in the tests:
> 
> [...]
> 
> > Judging from this, I am inclined to think that msgpack does not use
> > these two headers for anything but tests.  But I am not sure about
> > this.
> 
> I think that another application would call the zbuffer functions,
> although the string 'zbuffer' does not exist in the opendht source code.
> But, we should make sure msgpack will work for other calling
> applications that might be added later.
> 
> On #guix, bavier suggested we patch 'msgpack.pc.in'. Specifically, we
> should append the include flag to 'Cflags:' and create a 'Libs.private:'
> field for the -L and -l flags. There are some examples in
> 'gnu/packages'.
> 
> More details on the IRC log:
> https://gnunet.org/bot/log/guix/2016-06-13#T1056507
> 
> I've cc-ed Eric since I don't know much about pkg-config.

Of course, I forgot to do this :p