[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add opendht.
From: |
Leo Famulari |
Subject: |
Re: [PATCH] Add opendht. |
Date: |
Tue, 31 May 2016 18:04:15 -0400 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On Tue, May 31, 2016 at 09:17:29AM -0500, Lukas Gradl wrote:
> * gnu/packages/telephony.scm (opendht): New variable.
I wonder if there is a better module? Distributed hash tables aren't
specific to telephony.
> +(define-public opendht
> + (let ((commit "13f8c13ac4ebb3b43474d91ca48b42a1019083f4"))
> + ;; This is the commit used by the Ring Project.
If Ring works with the latest tagged release, then I think we should use
that instead of the Git commit. They released only 3 days ago, so it's
unlikely that Ring needs some feature that's not in the tarball.
> + (inputs
> + `(("gnutls" ,gnutls)
> + ("nettle" ,nettle)
> + ("msgpack" ,msgpack)
> + ("readline" ,readline)))
I noticed they bundle Argon2, which is a password hashing library:
https://github.com/savoirfairelinux/opendht/tree/master/src/argon2
I think we should delete the bundled library in an origin snippet and
make opendht use an external package.
> + (native-inputs
> + `(("autoconf" ,autoconf)
> + ("pkg-config" ,pkg-config)
> + ("automake" ,automake)
> + ("libtool" ,libtool)))
> + (arguments
> + `(#:configure-flags '("--disable-tools" "--disable-python")
> + #:phases (modify-phases %standard-phases
> + (add-before 'configure 'autoconf
> + (lambda _
> + (zero? (system* "autoreconf" "-vfi")))))))
If we package a tagged release, it's possible that we won't need to
bootstrap.
> + (license gpl3))))
I skimmed the source files, and most of them said "either version 3 of
the License, or (at your option) any later version.", so we should use
gpl3+.