|
From: | Ludovic Courtès |
Subject: | Re: [PATCH 1/7] import cran: Remove more invalid characters from package names. |
Date: | Mon, 30 May 2016 10:48:36 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ricardo Wurmus <address@hidden> skribis: > * guix/import/cran.scm (guix-name): Replace period and underscore with > dash; always prepend package names with "r-". [...] > + (string-append "r-" (string-downcase > + (regexp-substitute/global #f "(_|\\.)" name > + 'pre "-" 'post)))) I have a preference fro ‘string-map’, which I find more readable than ‘regexp-substitute/global’ in simple cases. Thoughts? Otherwise LGTM! Thanks, Ludo’.
[Prev in Thread] | Current Thread | [Next in Thread] |