[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Emacs Zenburn
From: |
Alex Kost |
Subject: |
Re: [PATCH] Emacs Zenburn |
Date: |
Tue, 17 May 2016 21:10:03 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Catonano (2016-05-17 13:12 +0300) wrote:
> I made a new patch trying to adhere to your indications
>
> Only, I'm having troubles with git-send-email so now I'm trying to attach
> the new patch to this email in a different way, maybe this time you can
> access it ?
Yes, perfect, thanks!
> From 359d604b8cfb42726efc932a9002e7d69f439f83 Mon Sep 17 00:00:00 2001
> From: humanitiesNerd <address@hidden>
> Date: Tue, 17 May 2016 10:54:13 +0200
> Subject: [PATCH] gnu: Add emacs-zenburn-theme
As I wrote in the previous message, the commit message should be:
gnu: Add emacs-zenburn-theme.
* gnu/packages/emacs.scm (emacs-zenburn-theme): New variable.
Please keep it in mind next time ;-)
> ---
> gnu/packages/emacs.scm (emacs-zenburn-theme): New variable | 25
> +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index f0c1555..8bfcf5b 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1590,3 +1590,28 @@ to recognize a name like \"RFC 1234\". This package
> enhances ffap so
> that it correctly finds RFCs even when a space appears before the
> number.")
> (license license:gpl3+)))
> +
> +(define-public emacs-zenburn-theme
> + (package
> + (name "emacs-zenburn-theme")
> + (version "2.4")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/bbatsov/zenburn-emacs/archive/v"
> + version
> + ".tar.gz"))
"guix lint emacs-zenburn-theme" reports that «the source file name
should contain the package name». This happens because (by default)
this tarball has the following name in the store:
/gnu/store/…-v2.4.tar.gz
It is better to have something more understandable, like:
/gnu/store/…-emacs-zenburn-theme-2.4.tar.gz
This can be achieved by adding the following line to the 'origin':
(file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "0lyi84bm8sa7vj40n6zg6rlbsmi53mi1y9xn6gkjj29s5zbcnlg7"))))
> + (build-system emacs-build-system)
> + (home-page "http://github.com/bbatsov/zenburn-emacs")
> + (synopsis
> + "Low contrast color theme for Emacs")
> + (description
> + "Zenburn theme is a port of the popular Vim Zenburn theme for Emacs.
> +It is built on top of the custom theme support in Emacs 24 or later")
> + (license license:gpl3+)))
I made the mentioned changes, added a copyright line for you and
committed it as 9576cc7¹. Thanks for contributing!
¹
http://git.savannah.gnu.org/cgit/guix.git/commit/?id=9576cc72dc4f2973551c72951e64e5bf6240ff6b
--
Alex