[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add wmfire.
From: |
Alex Kost |
Subject: |
Re: [PATCH] gnu: Add wmfire. |
Date: |
Sat, 07 May 2016 10:27:48 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Kei Yamashita (2016-05-07 01:44 +0300) wrote:
> Adding another dockapp.
>
> From dd367c87eab125d83875e98e27489191d60cd735 Mon Sep 17 00:00:00 2001
> From: Kei Yamashita <address@hidden>
> Date: Fri, 6 May 2016 17:24:44 -0400
> Subject: [PATCH] gnu: Add wmfire.
>
> * gnu/packages/gnustep.scm (wmfire): New variable.
> ---
> gnu/packages/gnustep.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/gnustep.scm b/gnu/packages/gnustep.scm
> index f4a2b26..20306b1 100644
> --- a/gnu/packages/gnustep.scm
> +++ b/gnu/packages/gnustep.scm
> @@ -24,6 +24,7 @@
> #:use-module (guix licenses)
> #:use-module (gnu packages xorg)
> #:use-module (gnu packages gnome)
> + #:use-module (gnu packages gtk)
> #:use-module (gnu packages texinfo)
> #:use-module (gnu packages autotools)
> #:use-module (gnu packages glib)
> @@ -216,3 +217,32 @@ on.")
> a dockable tile. It features multiple language support, 24h or 12h time
> display, and can run a user-specified program on mouse click.")
> (license gpl2+)))
> +
> +(define-public wmfire
> + (package
> + (name "wmfire")
> + (version "1.2.4")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "http://www.improbability.net/"
> + name "/" name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "101grahd80n97y2dczb629clmcgiavdpbbwy78kk5wgs362m12z3"))))
> + (build-system gnu-build-system)
> + (inputs
> + `(("gtk+" ,gtk+-2)
> + ("libgtop" ,libgtop)))
> + (native-inputs
> + `(("autoconf" ,autoconf)
> + ("automake" ,automake)
> + ("pkg-config" ,pkg-config)))
There is no need to include "autoconf" and "automake" here. I see there
are warnings like this:
WARNING: `autoconf' is missing on your system. You should only need it if
you modified `configure.in'. You might want to install the
`Autoconf' and `GNU m4' packages. Grab them from any GNU
archive site.
but they are harmless. So I think only "pkg-config" should be put in
'native-inputs'.
> + (home-page "http://www.improbability.net/")
> + (synopsis "Displays flames to monitor CPU, memory, etc.")
I don't really understand this synopsis, but it's probably just me.
Anyway I think "Displays" is not the preferred form; rather "Display".
> + (description
> + "This applet can monitor the average cpu load, or individual cpu load on
> +SMP computers. Additionally it can monitor the memory, network load, a file
> or
> +just be set to show a pretty flame. On entering the dock a burning spot
> +replaces the cursor, and after two seconds symbols to represent the current
> +monitor are \"burnt\" onscreen. The flame colour can also be changed.")
I think it is good to mention that this applet is for Window Maker as
you did for 'wmlock' package.
> + (license gpl2+)))
--
Alex (who thinks it's time to add commit rights to Kei)