[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Gnome-updates
From: |
宋文武 |
Subject: |
Re: Gnome-updates |
Date: |
Mon, 02 May 2016 22:47:16 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> Hello!
>
> address@hidden (宋文武) skribis:
>
>> - Disable a failing rtprtx test of gst-plugins-good.
>> I can pass it using `guix environment', but fail with `guix build'.
>
> The log for this commit contains a typo: it doesn’t mention the variable
> name, only the ‘arguments’ field. Also, could you add a comment that
> says why we disable this test?
>
> With this comment, I think it’s OK.
Oh, thanks!
>
>> - Add xdg-desktop-database and xdg-mime-database hooks.
>> I pick it from my old branch, and notice that my old code really
>> requires shared-mime-info and desktop-file-utils to be installed
>> explicitly.. So I factor out the 'manifest-lookup-package' proceduce
>> used by gtk-icon-themes to allow find them in the propagated-inputs
>> in manifest. (or maybe I should lookup for glib? but I think it's
>> ok now since I add them to the gnome meta package)
>
> Sounds good, but it’s not directly related to this branch, is it? Would
> have been best to submit for inclusion in ‘master’, if possible.
Yes..
>
> At first sight these 3 patches look good.
>
>> - Drop the 'loaders.cache' file from librsvg.
>> Since we have use gdk-pixbuf+svg for gtk+, gtk+ applications can use
>> SVG without wrap with it. I have tested key-mon (works), but not
>> solfege (too slow to download texlive..).
>
> OK.
>
>> - Disable the Spell plugin of gedit.
>> It now needs gspell, which doesn't work due to enchant can't list
>> dicts of aspell. Report it as:
>> <https://lists.gnu.org/archive/html/aspell-devel/2016-04/msg00004.html>
>> (Does it works before?)
>
> No idea, but OK. (Thanks for emailing the Aspell folks!)
>
>> - Skip 'test_utf8_inout' of gjs.
>> it fails with gobject-introspection-1.48.0, but use python3 to
>> call the test in Regress.typelib will pass. Report as:
>> <https://bugzilla.gnome.org/show_bug.cgi?id=765465>
>> (No one notice yet.)
>
> I would prefer this one to be fixed, because it’s worrisome that such a
> basic feature is broken.
Agree, but the only user of gjs is gnome-shell, and it seems works,
so I guess we could leave it for later?
>
> The bug report above mentions a dangling pointer. Do you have a
> backtrace or something to illustrate that? Did you set a breakpoint on
> ‘regress_test_utf8_inout’ or something?
No, I find it with some print functions..
>
>> Also, 1 test of libsoup on x86_64 fails (other systems fine):
>> <http://hydra.gnu.org/build/1180730>.
>> Should we skip it, or retry the build on hydra?
>
> The failing test is:
>
> ERROR: multipart-test - exited with status 139 (terminated by signal 11?)
>
> Signal 11 doesn’t sound good. :-)
>
> However, I can’t reproduce it on my machine:
>
> $ ./pre-inst-env guix build libsoup --check --no-grafts -q
> /gnu/store/km0g7xmsngs1yd8ix08pkifk152qifss-libsoup-2.54.1
> /gnu/store/fbq6hal96vfy556sybzwhyj879w8pgr5-libsoup-2.54.1-doc
> $ git describe
> v0.10.0-612-g0a24549
>
> So unless someone can reproduce it and get more info, I’d be in favor of
> retrying.
OK.
Thanks for the review.
I have rebase it upon master again with the one log change but
leave out the poppler CVE-2015-8868 fix (it's in 0.42.0) in master.
(I can't use force push so I delete and push it again..)