guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/10] gnu: Add python-barbicanclient.


From: Leo Famulari
Subject: Re: [PATCH 10/10] gnu: Add python-barbicanclient.
Date: Sat, 30 Apr 2016 17:33:54 -0400
User-agent: Mutt/1.5.24 (2015-08-30)

On Fri, Apr 29, 2016 at 04:21:03PM +0200, Cyril Roelandt wrote:
> * gnu/packages/openstack.scm (python-barbicanclient, python2-barbicanclient):
> New variables.
> * gnu/packages/patches/python-barbicanclient-assertItemsEqual.patch: New file.
> * gnu/local.ml: Add it here.

Can you use "* gnu/local.mk (dist_patch_DATA)"?

> +        (patches (search-patches
> +                  ;; testtools.TestCase.assertItemsEqual does not exist in 
> our
> +                  ;; version of testtools. Remove this patch once we update
> +                  ;;testtools.

Can you copy this comment into the patch itself?

> +    (native-inputs
> +      ;; Tests
> +      `(("python-setuptools" ,python-setuptools)

I think you could move the comment to this space. Also, is setuptools
needed for the python-3 version?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]