guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] guix: use '@' in package-full-name instead of '-'


From: Mathieu Lirzin
Subject: Re: [PATCH] guix: use '@' in package-full-name instead of '-'
Date: Thu, 28 Apr 2016 10:23:16 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Cyril Roelandt <address@hidden> writes:

> * guix/packages.scm (package-full-name): Use '@' instead of '-'.
> ---
>  guix/packages.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index d62d1f3..e33791e 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -346,7 +346,7 @@ name of its URI."
>  
>  (define (package-full-name package)
>    "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
> -  (string-append (package-name package) "-" (package-version package)))
> +  (string-append (package-name package) "@" (package-version package)))
>  
>  (define (%standard-patch-inputs)
>    (let* ((canonical (module-ref (resolve-interface '(gnu packages base))

Unfortunately, changing this is not as simple.

When implementing the '-' to '@' thing, I have proposed to switch
‘package-full-name’.  While I still think it would make sense for it to
use '@', it would require a full rebuild of every package + extra care.
For example among other things the tests will not be happy for ‘guix
graph‘ IIRC, and the Guix website uses it to access Hydra links.

It would be great if you manage to solve this issue.  :)

Thanks,

-- 
Mathieu Lirzin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]