[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add Piranha.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Add Piranha. |
Date: |
Wed, 27 Apr 2016 14:30:19 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ricardo Wurmus <address@hidden> skribis:
> From 8ebcd50666e13407d2b74907c9bc5e37ee420192 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Tue, 26 Apr 2016 16:08:47 +0200
> Subject: [PATCH] gnu: Add Piranha.
>
> * gnu/packages/bioinformatics.scm (piranha): New variable.
[...]
> + (add-after 'unpack 'copy-smithlab-cpp
> + (lambda* (#:key inputs #:allow-other-keys)
> + (mkdir "src/smithlab_cpp")
> + (for-each (lambda (file)
> + (copy-file file
> + (string-append "./src/smithlab_cpp/"
> + (basename file))))
Rather:
(install-file file "src/smithlab_cpp")
> + ,(origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/smithlabcode/smithlab_cpp.git")
> + (commit "3723e2d")))
> + (file-name "smithlab_cpp-3723e2d-checkout")
Either remove the commit ID from ‘file-name’ or introduce a ‘commit’
variable to avoid repetition.
> + (home-page "https://github.com/smithlabcode/piranha")
> + (synopsis "Peak-caller for CLIP-seq and RIP-seq data")
> + (description
> + "Piranha is a peak-caller for CLIP-seq and RIP-seq data.")
Could you expound a bit (info "(guix) Synopses and Descriptions")? :-)
OK with these changes.
Thanks!
Ludo’.